[PATCH] D53980: [ARM, AArch64] Move ARM/AAch64 target parsers into separate files to enable future changes.

[Dave Green via Phabricator via llvm-commits]

dmgreen added reviewers: SjoerdMeijer, olista01, efriedma, peter.smith, t.p.northover.
dmgreen added a comment.

Hello! Drive by comments. I've not looked in any depth.



================
Comment at: include/llvm/Support/ARMTargetParser.h:189
+// Information by ID
+StringRef getFPUName(unsigned FPUKind);
+ARM::FPUVersion getFPUVersion(unsigned FPUKind);
----------------
Some of these are now here twice.


================
Comment at: lib/Support/ARMTargetParser.cpp:1
+#include "llvm/Support/ARMTargetParser.h"
+#include "llvm/ADT/StringSwitch.h"
----------------
You need to add file headers, same as in all other files in llvm.


================
Comment at: lib/Support/ARMTargetParser.cpp:425
+bool ARM::getExtensionFeatures(unsigned Extensions,
+                                     std::vector<StringRef> &Features) {
+
----------------
It's worth running clang-format over the patch, if you haven't done already.


Repository:
  rL LLVM

https://reviews.llvm.org/D53980