[PATCH] D53986: [LTO] Fix a crash caused by accessing an empty ValueInfo

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 2 16:26:56 PDT 2018


tejohnson added a comment.

In https://reviews.llvm.org/D53986#1286187, @tmroeder wrote:

> It looks like the sources match in both CHECK-DAG cases but that the destinations don't.


Thanks for testing! Ack, that makes sense and I should have realized earlier. For internal symbols, the path is included with the name when computing the guid, specifically so multiple locals with the same name are disambiguated. So the rhs of the -> will be different when running the test in different places! Will upload a fix with a looser matching shortly.


Repository:
  rL LLVM

https://reviews.llvm.org/D53986





More information about the llvm-commits mailing list