[PATCH] D54049: [DWARF v5] Verifier: Add checks for DW_FORM_strx* forms.

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:643
+    Optional<uint64_t> StringOffset = DieCU->getStringOffsetSectionItem(Index);
+    assert(StringOffset); // Guaranteed to succeed at this point.
+    if (*StringOffset >= DObj.getStringSection().size()) {
----------------
probinson wrote:
> aprantl wrote:
> > I'm pretty sure Optional::operator* already asserts.
> In which case this could simplify to
> ```
> uint64_t StringOffset = *DieCU->getStringOffsetSectionItem(Index);
> if (StringOffset >= ...
> ```
> I'm pretty sure Optional::operator* already asserts.
It sure does. I'll get rid of the assert in the final commit.


https://reviews.llvm.org/D54049