[PATCH] D53842: [WebAssembly] Parsing missing directives to produce valid .o

[Wouter van Oortmerssen via Phabricator via llvm-commits]

aardappel marked an inline comment as done.
aardappel added inline comments.


================
Comment at: lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:363
+        return Error("Cannot parse .size expression: ", Lexer.getTok());
+      WasmSym->setSize(Exp);
+    } else if (DirectiveID.getString() == ".globaltype") {
----------------
sbc100 wrote:
> What isn't `ELFAsmParser::ParseDirectiveSize` which then calls `getStreamer().emitELFSize` doing this already?
As discussed offline will do this in a followup, as it requires our own implementation of ELFAsmParser


Repository:
  rL LLVM

https://reviews.llvm.org/D53842