[PATCH] D54049: [DWARF v5] Verifier: Add checks for DW_FORM_strx* forms.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 2 14:43:32 PDT 2018


aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:643
+    Optional<uint64_t> StringOffset = DieCU->getStringOffsetSectionItem(Index);
+    assert(StringOffset); // Guaranteed to succeed at this point.
+    if (*StringOffset >= DObj.getStringSection().size()) {
----------------
I'm pretty sure Optional::operator* already asserts.


https://reviews.llvm.org/D54049





More information about the llvm-commits mailing list