[PATCH] D53727: Only call FlushFileBuffers when writing executables

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Looks good, but when you commit it, you probably will want to keep an eye out for warnings or build breakages in other configurations. This code will be compiled with GCC, MSVC, and clang, and I can imagine a few ways the WindowsSupport.h code could raise warnings.



================
Comment at: lib/Support/Windows/WindowsSupport.h:76
+typedef NTSTATUS(WINAPI* RtlGetVersionPtr)(PRTL_OSVERSIONINFOW);
+#define STATUS_SUCCESS ((NTSTATUS)0x00000000L)
+
----------------
Does this really not conflict with the windows.h include above?


================
Comment at: lib/Support/Windows/WindowsSupport.h:95
+  info.dwOSVersionInfoSize = sizeof(OSVERSIONINFOEX);
+#pragma warning(push)
+#pragma warning(disable : 4996)
----------------
Oh, do these need to be #ifdef _MSC_VER? Will we get the deprecation warning in a clang-cl build?


https://reviews.llvm.org/D53727