[PATCH] D53384: [PowerPC] Make no-PIC default to match GCC - CLANG

[Stefan Pintilie via Phabricator via llvm-commits]

stefanp added inline comments.


================
Comment at: test/Driver/print-multi-directory.c:7
 
-// CHECK-X86-MULTILIBS:      32
+// CHECK-X86-MULTILIBS:      .
 // CHECK-X86-MULTILIBS-NOT:  {{^.+$}}
----------------
nemanjai wrote:
> sfertile wrote:
> > stefanp wrote:
> > > jsji wrote:
> > > > Do we know why this changes due to fPIC default change?  
> > > > If this is a non-relevant change, maybe deliver in another NFC commit? Thanks.
> > > No I don't know exactly why this changes.
> > > I was actually debating in this situation whether or not I should just add -fPIC to the options to keep the behaviour the same as before. 
> > > 
> > > Unfortunately I can't put this in a later NFC change because I would leave a failing test. I either have to adjust the test or I would have to add -fPIC. 
> > This test changing  behavior is suspect, the run line uses a target that is not powerpc and if the test somehow depended on the hosts default pic value wouldn't it be failing for mips64 as well? FWIW I applied this change to top-of-trunk and ran the test an X86 machine and the test behavior didn't change. I think it worth investigating to find out why this test changes behavior due to this change.
> @stefanp You need to figure out what is going on with this test case for you. I have tried this on PPC as well and the test case did *not* change behaviour.
I got to the bottom of this issue.
It was a mistake on my part. The snapshot that I had for llvm had that test failing before I added my change.
This test has nothing to do with my change at all and I so won't modify it.
Sorry for the confusion... :( 


https://reviews.llvm.org/D53384