[llvm] r346031 - [WebAssembly] Change indices types to unsined int (NFC)
Heejin Ahn via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 2 12:25:09 PDT 2018
Author: aheejin
Date: Fri Nov 2 12:25:09 2018
New Revision: 346031
URL: http://llvm.org/viewvc/llvm-project?rev=346031&view=rev
Log:
[WebAssembly] Change indices types to unsined int (NFC)
Summary:
This changes int types to unsigned int in a few places: function indices
and `wasm::Valtype` (which is unsigend int enum). Currently these
values cannot have negative values anyway, so this should not be a
functional change for now.
Reviewers: sbc100
Subscribers: dschuff, jgravelle-google, sunfish, llvm-commits
Differential Revision: https://reviews.llvm.org/D54044
Modified:
llvm/trunk/lib/MC/WasmObjectWriter.cpp
Modified: llvm/trunk/lib/MC/WasmObjectWriter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/WasmObjectWriter.cpp?rev=346031&r1=346030&r2=346031&view=diff
==============================================================================
--- llvm/trunk/lib/MC/WasmObjectWriter.cpp (original)
+++ llvm/trunk/lib/MC/WasmObjectWriter.cpp Fri Nov 2 12:25:09 2018
@@ -92,9 +92,9 @@ struct WasmFunctionTypeDenseMapInfo {
static unsigned getHashValue(const WasmFunctionType &FuncTy) {
uintptr_t Value = FuncTy.State;
for (wasm::ValType Ret : FuncTy.Returns)
- Value += DenseMapInfo<int32_t>::getHashValue(int32_t(Ret));
+ Value += DenseMapInfo<uint32_t>::getHashValue(uint32_t(Ret));
for (wasm::ValType Param : FuncTy.Params)
- Value += DenseMapInfo<int32_t>::getHashValue(int32_t(Param));
+ Value += DenseMapInfo<uint32_t>::getHashValue(uint32_t(Param));
return Value;
}
static bool isEqual(const WasmFunctionType &LHS,
@@ -118,7 +118,7 @@ struct WasmDataSegment {
// A wasm function to be written into the function section.
struct WasmFunction {
- int32_t Type;
+ uint32_t Type;
const MCSymbolWasm *Sym;
};
@@ -231,7 +231,7 @@ class WasmObjectWriter : public MCObject
// Map from section to defining function symbol.
DenseMap<const MCSection *, const MCSymbol *> SectionFunctions;
- DenseMap<WasmFunctionType, int32_t, WasmFunctionTypeDenseMapInfo>
+ DenseMap<WasmFunctionType, uint32_t, WasmFunctionTypeDenseMapInfo>
FunctionTypeIndices;
SmallVector<WasmFunctionType, 4> FunctionTypes;
SmallVector<WasmGlobal, 4> Globals;
More information about the llvm-commits
mailing list