[PATCH] D51524: [ARM64] [Windows] Handle funclets

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 2 12:25:13 PDT 2018


efriedma added a comment.

I'm not really an expert on funclets, but the code looks fine to me.

The test coverage here is a little thin... in particular, there isn't any coverage of the emitted unwind opcodes.  I'll amend the testcase to check the llvm-readobj output. (Sanjin isn't available for the next few weeks, so I'm going to handle any further revisions to the patch.)

Reid, do you have an opinion on what test coverage is necessary here?


Repository:
  rL LLVM

https://reviews.llvm.org/D51524





More information about the llvm-commits mailing list