[PATCH] D53986: [lto] Fix a crash caused by accessing an empty ValueInfo

Fri Nov 2 12:07:03 PDT 2018

tejohnson added a comment.

In https://reviews.llvm.org/D53986#1285818, @tmroeder wrote:

> In https://reviews.llvm.org/D53986#1285797, @tejohnson wrote:
>
> > In https://reviews.llvm.org/D53986#1285573, @tejohnson wrote:
> >
> > > The change looks ok to me now, but we really need a test case for this. I tried unsuccessfully so far to induce the error. Was this produced when using the save-temps plugin-opt during your ThinLTO link? Can you go into the debugger and see what the value of E.Dst is?
> > >
> > > I'm also at Google so feel free to reach out to me internally if your reproducer can't be shared upstream.
> >
> >
> > Via the test case Tom provided me, I can see what is going on. This is from an aliasee, where the aliasee is internal linkage, and because it has internal linkage and there are multiple internal symbols with the same name and internal linkage we are not able to get the GUID from the original GUID. I have a more robust fix, and can create a test case. Mind if I commandeer this patch?
>
>
> Sure, no problem. I don't know Phabricator well, so please let me know if there's something I need to do.

Nope, I can do it. I'll do so when I have something ready to upload later today.

Repository:
  rL LLVM

https://reviews.llvm.org/D53986