[PATCH] D53842: [WebAssembly] Parsing missing directives to produce valid .o

[Wouter van Oortmerssen via Phabricator via llvm-commits]

aardappel marked 16 inline comments as done.
aardappel added inline comments.


================
Comment at: lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:396
+        return Error("Cannot parse .size expression: ", Lexer.getTok());
+      LastFunction->setSize(Exp);
     } else if (DirectiveID.getString() == ".param" ||
----------------
aardappel wrote:
> sbc100 wrote:
> > Isn't `.size` already handled by the ELFAsmParser, e.g. `ELFAsmParser::ParseDirectiveSize`?  Or do we not use the ELFAsmParser at all anymore?
> Without me parsing this, the binary writer would complain the size wasn't set. I'll look into it.
Yes, ELFAsmParser::ParseDirectiveSize is never called while assembling with llvm-mc.


Repository:
  rL LLVM

https://reviews.llvm.org/D53842