[PATCH] D53992: [DebugInfo] Correctly sink DBG_VALUEs in postra-machine-sink

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 2 08:47:21 PDT 2018


aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

one more documentation request inline.



================
Comment at: lib/CodeGen/MachineSink.cpp:737
 
 /// Sink an instruction and its associated debug instructions.
 static void performSink(MachineInstr &MI, MachineBasicBlock &SuccToSinkTo,
----------------
Please document what the optional DbgVals parameter is for. The next time someone reads this function they will be very confused about it :-)


https://reviews.llvm.org/D53992





More information about the llvm-commits mailing list