[PATCH] D53975: Start adding the supporting code to perform out-of-process allocator enumeration.

[Dan Liew via Phabricator via llvm-commits]

delcypher added a comment.

> Why is `EnsureSortedChunks()` even called at all? I see nothing in the iteration code that would actually trigger a sort.
>  During the call to `ForEachChunk(...)` the allocator is also supposed to be locked so other threads won't be able to trigger a sort either. This suggests to me that the call to `EnsureSortedChunks()` is unnecessary, even on the in-process path. If we remove that then this `ObjectView::IsLocal()` guard issue just goes away.

Okay I figured it out. It's the callback that could trigger a sort. The current callback implementations call things like `GetUserBegin()` which can eventually trigger a call in the allocator to `GetBlockBeginFastLocked()` which will try to sort the chunks.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D53975