[PATCH] D54006: Fix a few small issues in llvm-pdbutil

[Zachary Turner via Phabricator via llvm-commits]

zturner added a comment.

Out of curiosity, is this a PDB you generated yourself by compiling something and running pdbstrip on it?



================
Comment at: test/tools/llvm-pdbdump/stripped.test:4-5
+
+; CHECK: Summary                           
+; CHECK-NEXT: ============================================================
+
----------------
Can you print the rest of this section?  For example, I think there's actually a field here that says it's stripped.


================
Comment at: test/tools/llvm-pdbdump/stripped.test:7-8
+
+; CHECK: Streams                           
+; CHECK-NEXT: ============================================================
+
----------------
This section might be interesting to print too.  If for no other reason than to server as a reference of what streams are "normal" to expect in a stripped PDB.


================
Comment at: tools/llvm-pdbutil/InputFile.cpp:182-183
 
   DebugStream = std::make_shared<ModuleDebugStreamRef>(std::move(*MDS));
+  assert(DebugStream);
   Subsections = DebugStream->getSubsectionsArray();
----------------
This assert doesn't seem necessary, as it's essentially checking for an out of memory condition.


Repository:
  rL LLVM

https://reviews.llvm.org/D54006