[PATCH] D53964: [WebAssembly] Expand inserts and extracts with variable indices
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 1 15:19:53 PDT 2018
aheejin accepted this revision.
aheejin added a comment.
This revision is now accepted and ready to land.
Great that we can do this without doing crazy things! LGTM with one nit.
================
Comment at: lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1078
+ else
+ return SDValue();
+}
----------------
Maybe add comments on what this is supposed to do?
Repository:
rL LLVM
https://reviews.llvm.org/D53964
More information about the llvm-commits
mailing list