[PATCH] D53625: [WebAssembly] General vector shift lowering

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1072
+
+  // Non-const splats are handled by patterns, except for i64x2
+  ConstantSDNode *SplatConst = dyn_cast<ConstantSDNode>(SplatVal);
----------------
This comment is confusing, because it sounds like i64x2 non-const splats are not handled by patterns. But by looking at the code, it looks like
- non-i64x2 non-const splat: handled by pattern
- i64x2 non-const splat: handled by pattern
- non-i64x2 const splat: handled by pattern
- i64x2 const splat: custom lowering

So the only case we use the custom logic below is i64x2 const splat, right? I think the comment says otherwise.


Repository:
  rL LLVM

https://reviews.llvm.org/D53625