[PATCH] D53997: [gold-plugin] Fix a bunch of build warnings

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: tools/gold/gold-plugin.cpp:450
   case DS_Error:
-    message(LDPL_FATAL, "LLVM gold plugin has failed to create LTO module: %s",
+    message(Level, "LLVM gold plugin has failed to create LTO module: %s",
             ErrStorage.c_str());
----------------
Thanks for the fix. I am not sure in fact why we need this separate call to message, rather than just allowing the code to fall through and use the one below the switch statement. I don't see value in the different style of message, particularly now with ThinLTO (looks like this code is quite old, predating ThinLTO).

Can you just remove the call to message() here and instead set Level = LDPL_FATAL here?


Repository:
  rL LLVM

https://reviews.llvm.org/D53997