[llvm] r345894 - Silence -Wimplicit-fallthrough in gold plugin

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 1 14:24:34 PDT 2018


Author: rnk
Date: Thu Nov  1 14:24:33 2018
New Revision: 345894

URL: http://llvm.org/viewvc/llvm-project?rev=345894&view=rev
Log:
Silence -Wimplicit-fallthrough in gold plugin

Fatal errors are likely fatal, but in case they aren't, return instead
of printing a second warning.

Modified:
    llvm/trunk/tools/gold/gold-plugin.cpp

Modified: llvm/trunk/tools/gold/gold-plugin.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/gold/gold-plugin.cpp?rev=345894&r1=345893&r2=345894&view=diff
==============================================================================
--- llvm/trunk/tools/gold/gold-plugin.cpp (original)
+++ llvm/trunk/tools/gold/gold-plugin.cpp Thu Nov  1 14:24:33 2018
@@ -449,6 +449,7 @@ static void diagnosticHandler(const Diag
   case DS_Error:
     message(LDPL_FATAL, "LLVM gold plugin has failed to create LTO module: %s",
             ErrStorage.c_str());
+    return;
   case DS_Warning:
     Level = LDPL_WARNING;
     break;




More information about the llvm-commits mailing list