[PATCH] D53877: [IR] Strawman for dedicated FNeg IR instruction

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 1 13:31:12 PDT 2018


cameron.mcinally added inline comments.


================
Comment at: lib/IR/Verifier.cpp:3011
+    llvm_unreachable("Unknown BinaryOperator opcode!");
+  }
+
----------------
arsenm wrote:
> cameron.mcinally wrote:
> > Just caught this bad copy-and-paste. Will address in next revision...
> Missing failing verifier tests
I'm not familiar with the Verifier tests, so please excuse my naivete...

Is it possible to trip these asserts with llvm-as? It looks like the parser will catch an incorrect type on the operand before we get to these asserts.


Repository:
  rL LLVM

https://reviews.llvm.org/D53877





More information about the llvm-commits mailing list