[llvm] r345883 - [Hexagon] Remove unintended fallthrough from MC duplex code

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 1 12:59:27 PDT 2018


Author: rnk
Date: Thu Nov  1 12:59:27 2018
New Revision: 345883

URL: http://llvm.org/viewvc/llvm-project?rev=345883&view=rev
Log:
[Hexagon] Remove unintended fallthrough from MC duplex code

I added these annotations in r345878 because I wasn't sure if the
fallthrough was intended. Krzysztof Parzyszek confirmed that they should
be breaks, so that's what this patch does.

Reviewers: kparzysz

Differential Revision: https://reviews.llvm.org/D53991

Modified:
    llvm/trunk/lib/Target/Hexagon/MCTargetDesc/HexagonMCDuplexInfo.cpp

Modified: llvm/trunk/lib/Target/Hexagon/MCTargetDesc/HexagonMCDuplexInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Hexagon/MCTargetDesc/HexagonMCDuplexInfo.cpp?rev=345883&r1=345882&r2=345883&view=diff
==============================================================================
--- llvm/trunk/lib/Target/Hexagon/MCTargetDesc/HexagonMCDuplexInfo.cpp (original)
+++ llvm/trunk/lib/Target/Hexagon/MCTargetDesc/HexagonMCDuplexInfo.cpp Thu Nov  1 12:59:27 2018
@@ -127,7 +127,7 @@ unsigned HexagonMCInstrInfo::iClassOfDup
     case HexagonII::HSIG_A:
       return 0x4;
     }
-    LLVM_FALLTHROUGH; // FIXME: Intentional?
+    break;
   case HexagonII::HSIG_L2:
     switch (Gb) {
     default:
@@ -139,7 +139,7 @@ unsigned HexagonMCInstrInfo::iClassOfDup
     case HexagonII::HSIG_A:
       return 0x5;
     }
-    LLVM_FALLTHROUGH; // FIXME: Intentional?
+    break;
   case HexagonII::HSIG_S1:
     switch (Gb) {
     default:
@@ -153,7 +153,7 @@ unsigned HexagonMCInstrInfo::iClassOfDup
     case HexagonII::HSIG_A:
       return 0x6;
     }
-    LLVM_FALLTHROUGH; // FIXME: Intentional?
+    break;
   case HexagonII::HSIG_S2:
     switch (Gb) {
     default:
@@ -169,7 +169,7 @@ unsigned HexagonMCInstrInfo::iClassOfDup
     case HexagonII::HSIG_A:
       return 0x7;
     }
-    LLVM_FALLTHROUGH; // FIXME: Intentional?
+    break;
   case HexagonII::HSIG_A:
     switch (Gb) {
     default:
@@ -177,7 +177,7 @@ unsigned HexagonMCInstrInfo::iClassOfDup
     case HexagonII::HSIG_A:
       return 0x3;
     }
-    LLVM_FALLTHROUGH; // FIXME: Intentional?
+    break;
   case HexagonII::HSIG_Compound:
     switch (Gb) {
     case HexagonII::HSIG_Compound:




More information about the llvm-commits mailing list