[PATCH] D53950: Enable -Wimplicit-fallthrough for clang as well as GCC

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: clang/lib/AST/ExprConstant.cpp:11146
     }
-
-    // OffsetOf falls through here.
-    LLVM_FALLTHROUGH;
+    llvm_unreachable("invalid unary operator class");
   }
----------------
rnk wrote:
> bogner wrote:
> > Could you commit this case (and the one below) separately? While most of the changes in this patch are mechanical, this one is arguably a correctness fix.
> Sure, there's this and a couple others, like the AArch64ISelLowering one.
This became rC345862.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:11039-11040
                                            const TargetMachine &TM) {
-  auto *GN = dyn_cast<GlobalAddressSDNode>(N);
-  if (!GN || Subtarget->ClassifyGlobalReference(GN->getGlobal(), TM) !=
-                 AArch64II::MO_NO_FLAG)
+  auto *GN = cast<GlobalAddressSDNode>(N);
+  if (Subtarget->ClassifyGlobalReference(GN->getGlobal(), TM) !=
+      AArch64II::MO_NO_FLAG)
----------------
alexfh wrote:
> This looks like something that's better to commit separately.
This became rL345864.


================
Comment at: llvm/lib/Target/Hexagon/HexagonConstExtenders.cpp:791
       assert(Offset == 0);
+      return MachineOperand::CreateJTI(V.ImmVal, TF);
     default:
----------------
alexfh wrote:
> Commit bug fixes separately?
This became rL345868.


https://reviews.llvm.org/D53950