[PATCH] D53950: Enable -Wimplicit-fallthrough for clang as well as GCC

[Alexander Kornienko via Phabricator via llvm-commits]

alexfh added a comment.

Great! Thanks for picking this up and pushing forward!



================
Comment at: clang/lib/Analysis/FormatString.cpp:692
       }
-      // Fall through.
+      LLVM_FALLTHROUGH; // Fall through.
     case LengthModifier::AsChar:
----------------
None of these comments seem useful.


================
Comment at: clang/tools/clang-func-mapping/ClangFnMapGen.cpp:85
             Index[LookupName] = CurrentFileName;
+	  break;
         default:
----------------
Incorrect indentation.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:11039-11040
                                            const TargetMachine &TM) {
-  auto *GN = dyn_cast<GlobalAddressSDNode>(N);
-  if (!GN || Subtarget->ClassifyGlobalReference(GN->getGlobal(), TM) !=
-                 AArch64II::MO_NO_FLAG)
+  auto *GN = cast<GlobalAddressSDNode>(N);
+  if (Subtarget->ClassifyGlobalReference(GN->getGlobal(), TM) !=
+      AArch64II::MO_NO_FLAG)
----------------
This looks like something that's better to commit separately.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:5053
+  case Intrinsic::amdgcn_workitem_id_x:
+  case Intrinsic::r600_read_tidig_x: {
     return loadInputValue(DAG, &AMDGPU::VGPR_32RegClass, MVT::i32,
----------------
Maybe remove the braces? There are none in the other cases.


================
Comment at: llvm/lib/Target/Hexagon/HexagonConstExtenders.cpp:791
       assert(Offset == 0);
+      return MachineOperand::CreateJTI(V.ImmVal, TF);
     default:
----------------
Commit bug fixes separately?


================
Comment at: llvm/lib/Target/Hexagon/HexagonConstExtenders.cpp:1211
         ED.Expr.Neg = true;
+	break;
       default:                        // (__: ## + __<<_)
----------------
Invalid indentation.


================
Comment at: llvm/lib/Target/Hexagon/HexagonVLIWPacketizer.cpp:1571
           }
+	  break;
         default:
----------------
Incorrect indentation


https://reviews.llvm.org/D53950