[llvm] r345879 - [codeview] Add breaks to fix -Wimplicit-fallthrough
Reid Kleckner via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 1 12:36:29 PDT 2018
Author: rnk
Date: Thu Nov 1 12:36:29 2018
New Revision: 345879
URL: http://llvm.org/viewvc/llvm-project?rev=345879&view=rev
Log:
[codeview] Add breaks to fix -Wimplicit-fallthrough
This is a minor bug fix. Previously, if you tried to encode the RSP
register on the x86 platform, that might have succeeded and been encoded
incorrectly. However, no existing producer or consumer passes the x86_64
registers when targeting x86_32.
Modified:
llvm/trunk/lib/DebugInfo/CodeView/SymbolRecordMapping.cpp
Modified: llvm/trunk/lib/DebugInfo/CodeView/SymbolRecordMapping.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/CodeView/SymbolRecordMapping.cpp?rev=345879&r1=345878&r2=345879&view=diff
==============================================================================
--- llvm/trunk/lib/DebugInfo/CodeView/SymbolRecordMapping.cpp (original)
+++ llvm/trunk/lib/DebugInfo/CodeView/SymbolRecordMapping.cpp Thu Nov 1 12:36:29 2018
@@ -529,6 +529,7 @@ EncodedFramePtrReg codeview::encodeFrame
default:
break;
}
+ break;
case CPUType::X64:
switch (Reg) {
case RegisterId::RSP:
@@ -540,6 +541,7 @@ EncodedFramePtrReg codeview::encodeFrame
default:
break;
}
+ break;
}
return EncodedFramePtrReg::None;
}
More information about the llvm-commits
mailing list