[PATCH] D53734: [GlobalISel] Fix a bug in LegalizeRuleSet::clampMaxNumElements

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 1 11:56:15 PDT 2018


dsanders added inline comments.


================
Comment at: test/CodeGen/AArch64/GlobalISel/legalize-load-fewerElts.mir:5-6
+# CHECK: Legalize Machine IR for: load_v4s32
+# CHECK-NEXT: %{{[0-9]+}}:_(<4 x s32>) = G_LOAD %{{[0-9]+}}:_(p0)
+# CHECK-NEXT: Reduce number of elements
+---
----------------
volkan wrote:
> dsanders wrote:
> > It's better to test the end result rather than the particular action the legalizer takes for this step. Can you drop the -debug-only=legalizer from the run line and test with the output you get without that?
> That was my plan, but D53728 is required to do that. I'll update the tests in D53728 after committing this.
Ok. That sounds good to me


https://reviews.llvm.org/D53734





More information about the llvm-commits mailing list