[PATCH] D53887: [HotColdSplitting] [WIP] Outline more than once per function

[Sebastian Pop via Phabricator via llvm-commits]

sebpop added a comment.

Maybe you can add the testcase from my previous patch: https://reviews.llvm.org/D53588



================
Comment at: llvm/lib/Transforms/IPO/HotColdSplitting.cpp:378
+      // If SinkBB does not dominate a successor, do not mark the successor (or
+      // anu of its successors) cold.
+      if (!SinkDom || !mayExtractBlock(SuccBB)) {
----------------
s/anu/any/


================
Comment at: llvm/lib/Transforms/IPO/HotColdSplitting.cpp:517
+      if (!isProfitableToOutline(SubRegion, TTI)) {
+        LLVM_DEBUG(dbgs() << "Skipping outlining; not profitable to outline\n");
+        continue;
----------------
hiraditya wrote:
> Maybe print the region which didn't get outlined, or at least the root-block.
I think that would generate too much debug output.  Maybe completely remove the LLVM_DEBUG stmt.


https://reviews.llvm.org/D53887