[PATCH] D53965: IR: Add fp operations to atomicrmw
JF Bastien via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 1 11:13:12 PDT 2018
jfb added a comment.
>> AFAIK we don't care about FP flags at all here, correct? Even `strictfp` is irrelevant.
>
> We can't algebraically combine this, so the flags shouldn't matter.
To clarify my concern: were LLVM to support fenv properly, this instruction can spuriously set FP flags if, say, the fadd executes in a loop and has spurious failure. The final store could hold a result which raised no FP exception, but intermediate results could have done so. But LLVM doesn't support fenv properly yet, so that's not an issue (I think!).
https://reviews.llvm.org/D53965
More information about the llvm-commits
mailing list