[PATCH] D53988: Close file mapping handle on Windows, so flushed gcda files can be removed while the process is in execution
Marco Castelluccio via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 1 11:13:10 PDT 2018
marco-c created this revision.
marco-c added a reviewer: calixte.
Herald added subscribers: Sanitizers, llvm-commits.
marco-c retitled this revision from "Close file mapping handle on Windows, so flushed gcda files can be removed while th" to "Close file mapping handle on Windows, so flushed gcda files can be removed while the process is in execution".
We were leaking it and it was "fine", but this way flushed gcda files can't be removed while the process is in execution.
This makes it impossible to collect coverage information for a subset of the execution.
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D53988
Files:
lib/profile/GCDAProfiling.c
test/profile/Inputs/instrprof-gcov-__gcov_flush-multiple.c
test/profile/Inputs/instrprof-gcov-__gcov_flush-multiple.c.gcov
test/profile/instrprof-gcov-__gcov_flush-multiple.test
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53988.172183.patch
Type: text/x-patch
Size: 5088 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181101/af6019ce/attachment.bin>
More information about the llvm-commits
mailing list