[PATCH] D53983: [llvm-objcopy] For multiclass Eq, associate help text with --name= , not --name

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, although please make sure that the whitespace is tidied up a bit, to make the indentation consistent, and reduce the number of long lines.



================
Comment at: tools/llvm-objcopy/ObjcopyOpts.td:10
 def help : Flag<["-", "--"], "help">;
-defm binary_architecture : Eq<"binary-architecture">,
-                           HelpText<"Used when transforming an architecture-less format (such as binary) to another format">;
+defm binary_architecture : Eq<"binary-architecture", "Used when transforming an architecture-less format (such as binary) to another format">;
 def B : JoinedOrSeparate<["-"], "B">,
----------------
Might be worth on some of these long lines to break it over two lines, e.g:

```
defm binary_architecture : Eq<"binary-architecture",
  "Used when transforming an architecture-less format (such as binary) to another format">;
```
or similar. Not sure about the indentation of the second line.


================
Comment at: tools/llvm-objcopy/ObjcopyOpts.td:93
 defm keep_global_symbols
-    : Eq<"keep-global-symbols">,
-      MetaVarName<"filename">,
-      HelpText<
-          "Reads a list of symbols from <filename> and runs as if "
+    : Eq<"keep-global-symbols",           "Reads a list of symbols from <filename> and runs as if "
 	  "--keep-global-symbol=<symbol> is set for each one. <filename> "
----------------
Something wacky has gone on with the spacing on this line...


Repository:
  rL LLVM

https://reviews.llvm.org/D53983