[PATCH] D53798: [lit] Add --show-substitutions
Dan Liew via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 1 06:20:35 PDT 2018
delcypher added inline comments.
================
Comment at: utils/lit/lit/main.py:352
+ if opts.showSubstitutions:
+ opts.showSuites = True
+
----------------
Why is showing substitutions coupled with listing the test suites?
================
Comment at: utils/lit/lit/main.py:433
+ for (pattern, replacement) in ts.config.substitutions:
+ if re.match(r'[\'"]|.*\s', pattern):
+ pattern = repr(pattern)
----------------
Is all this regex really necessary? Couldn't we just always print `repr(pattern), repr(replacement)`?
Repository:
rL LLVM
https://reviews.llvm.org/D53798
More information about the llvm-commits
mailing list