[PATCH] D52827: [LICM] Make LICM able to hoist phis

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 31 23:08:21 PDT 2018

Previous message: [PATCH] D52827: [LICM] Make LICM able to hoist phis
Next message: [PATCH] D53862: [compiler-rt] Pass CMake C and C++ flags to the custom libc++
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

mkazantsev added a comment.

I generally like what this patch is doing, but the size of code and its complexity overwhelms me. Is it possible to separate the patch into smaller pieces so that it would be easier to review them in isolation? If yes, I'd appreciate that a lot.


Repository:
  rL LLVM

https://reviews.llvm.org/D52827

Previous message: [PATCH] D52827: [LICM] Make LICM able to hoist phis
Next message: [PATCH] D53862: [compiler-rt] Pass CMake C and C++ flags to the custom libc++
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list