[PATCH] D53675: [WebAssembly] Lower select for vectors

[Thomas Lively via Phabricator via llvm-commits]

tlively added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:587
 
+multiclass SIMDSelectPat<ValueType vec_t, ValueType mask_t, ValueType lane_t,
+                         WebAssemblyRegClass reg_t> {
----------------
aheejin wrote:
> Why do we need this pattern? Can't we also expand `SELECT` as we did for `SELECT_CC` and `VSELECT`?
It looks like the expansions bottom out with `SELECT`. Even when select is set to expand, it still shows up in instruction selection.


Repository:
  rC Clang

https://reviews.llvm.org/D53675