[PATCH] D53957: [CodeView] Emit the correct TypeIndex for std::nullptr_t

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Looks good, thanks for the fix.



================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1518
   case dwarf::DW_TAG_unspecified_type:
-    return TypeIndex::None();
+    if (Ty->getName() != "decltype(nullptr)")
+      return TypeIndex::None();
----------------
I'd reverse this, so we have a special case for nullptr_t, and then the general case of "unspecified type" gives a type index of zero.


https://reviews.llvm.org/D53957