[PATCH] D53673: [COFF, ARM64] Implement Intrinsic.sponentry for AArch64

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:5184
+                                                      DAG.getMachineFunction()))
+      report_fatal_error("Intrinsic::sponentry requires frame pointer.");
+
----------------
This might become unnecessary.  But if it doesn't, please use setFrameAddressIsTaken to force a frame pointer to be emitted, instead of checking whether frame pointer elimination is enabled.


================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:5189
+  SDLoc DL(Op);
+  if (numFixed) {
+    int FI = MFI.CreateFixedObject(4, 0, false);
----------------
Do you need the "if" statement here?  CreateFixedObject should work whether or not there are other fixed objects, I think.


https://reviews.llvm.org/D53673