[PATCH] D53051: [llvm-tapi] initial commit, supports ELF text stubs

Mandeep Singh Grang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 31 12:02:29 PDT 2018


mgrang added inline comments.


================
Comment at: llvm/include/llvm/TAPI/ELFStubFile.h:83
+    }
+    std::sort(Stub.Symbols.begin(),
+              Stub.Symbols.end(),
----------------
Please use range based llvm::sort(Stub.Symbols, symbolCompareTo) instead of std::sort. 

See https://llvm.org/docs/CodingStandards.html#beware-of-non-deterministic-sorting-order-of-equal-elements


Repository:
  rL LLVM

https://reviews.llvm.org/D53051





More information about the llvm-commits mailing list