[PATCH] D49491: [RFC][VPlan, SLP] Add simple SLP analysis on top of VPlan.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: lib/Transforms/Vectorize/VPlanSLP.cpp:118
+
+  // For loads, check that there are no stores between them.
+  // FIXME: we only have to forbid stores that could interfere with any of the
----------------
Seems to me the comment does not match the functionality


================
Comment at: lib/Transforms/Vectorize/VPlanSLP.cpp:300
+  for (auto &Operands : MultiNodeOps) {
+    FinalOrder.push_back({Operands.first, {Operands.second[0]}});
+    if (cast<VPInstruction>(Operands.second[0])->getOpcode() ==
----------------
Try `FinalOrder.emplace_back(Operands.first, Operands.second[0]);`


https://reviews.llvm.org/D49491