[PATCH] D53596: [ThinLTO] Fix a crash in lazy loading of Metadata

Wed Oct 31 10:27:04 PDT 2018

tejohnson added a comment.

In https://reviews.llvm.org/D53596#1282167, @vsk wrote:

> Hi Teresa, with this patch applied, I do still see a (possibly unrelated) crash when building an internal framework with ThinLTO + hot/cold splitting. I'm not sure what the best way is to prepare a reproducer (please let me know), but I've tried to collect some output from the debugger:
>
> F7478619: Foundation-fmwk-ThinLTO-crash.txt <https://reviews.llvm.org/F7478619>

Doesn't look like this one has anything to do with the issue I'm fixing here. The stack trace shows it is coming from the call to materializeMetadata() from FunctionImport.cpp, and that is called before we invoke the IRMover (which is where we encountered the code with the bug, and the function changed by my patch). The code changed in this patch is not reached via materializeMetadata.

Can you file a new bug for the problem you encountered, along with some kind of reproducer? Looks like it might be hitting infinite, or at least very deep, recursion and running out of stack.

But what version are you on? The stack trace says the call to materializeMetadata is on line 765 of FunctionImport.cpp, and it is currently nowhere near that location and hasn't been in awhile.

Repository:
  rL LLVM

https://reviews.llvm.org/D53596