[PATCH] D53373: [CodeMetrics] Don't let extends of i1 be free.
Evgeny Astigeevich via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 31 09:48:08 PDT 2018
eastig added a comment.
Hi Jonas,
Thank for taking care of this. As this is legacy code without any tests some additional checks, such as runs of the LNT test suite, might be needed. This small change can affect the inliner or other optimisations and introduce regressions. I'll try to run the LNT benchmarks to check. You are welcome to do this as well.
I also suggest to add Chandler as a reviewer. Maybe Eli Friedman too?
Thanks,
Evgeny
https://reviews.llvm.org/D53373
More information about the llvm-commits
mailing list