[PATCH] D53887: [HotColdSplitting] [WIP] Outline more than once per function

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/HotColdSplitting.cpp:348
+      // function must be cold.
+      if (pred_empty(&PredBB)) {
+        ColdRegion.EntireFunctionCold = true;
----------------
vsk wrote:
> hiraditya wrote:
> > I think, this can go before the previous check.
> I think that would cause splitting to fail when a predecessor outside of the cold region is the entry block. Am I missing something?
When SinkPostDom is true and PredBB is the entry, we can just return.


https://reviews.llvm.org/D53887