[PATCH] D35035: [InstCombine] Prevent memcpy generation for small data size

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 31 07:55:46 PDT 2018


spatel added a comment.

In https://reviews.llvm.org/D35035#1281462, @lebedev.ri wrote:

> Not sure what is the general consensus wrt this patch, but i guess it now consistently uses bytes.


Agree - the code change looks like what I expected now.

So:

1. Is @jfb objecting to this as an intermediate improvement?
2. If not, there are unanswered comments about the test diffs.
3. There was also an unanswered request for the targets and size/perf improvements for this change (presumably some 32-bit target shows wins).
4. Are there any updates on the perf for the ideal change (removing this expansion completely)?


Repository:
  rL LLVM

https://reviews.llvm.org/D35035





More information about the llvm-commits mailing list