[PATCH] D53895: [LoopUnroll] add parsing for unroll parameters in -passes pipeline

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 31 03:20:57 PDT 2018


fedor.sergeev added a comment.

In https://reviews.llvm.org/D53895#1281931, @chandlerc wrote:

> Curious how others feel, but I'd prefer to keep all the parsing in the pass builder rather than start calling back into the passes. I think that keeps the passes more minimal, and I don't think this kind of parsing should he so widespread as to need separation. If a few passes have custom logic in pass builder that seems ok...


Sure thing I can keep the implementation of parser local to pass builder.
It needs to have a mapping for unroll parameter names, which does not really belong to pass builder,
but then it is a rather simple logic so there should not be any real harm...


Repository:
  rL LLVM

https://reviews.llvm.org/D53895





More information about the llvm-commits mailing list