[PATCH] D53804: [llvm-objdump] add support for '--reloc' as an alias of -r (PR39407)

[Kristina Brooks via Phabricator via llvm-commits]

kristina added a comment.

In https://reviews.llvm.org/D53804#1281913, @jhenderson wrote:

> In https://reviews.llvm.org/D53804#1281883, @Higuoxing wrote:
>
> > Is this version ok? Shall I update other options flag in another patch? Thanks a lot for your advice
>
>
> What you did is fine for now. I do think we should consider working on the command-line options a bit more in llvm-objdump. There are a few issues that I know of already, including https://bugs.llvm.org/show_bug.cgi?id=37895 (which covers the missing single-letter alias options in the help text) and https://bugs.llvm.org/show_bug.cgi?id=31679 (which points out that single-letter options don't combine properly (e.g. you can't do -fsr). The command-line options are also not GNU-compatible in some instances, in that they do different things. I'm going to raise a thread on the mailing list about this, if I get a chance, as to fix it, we'd have to change the meaning of some of the current options.


I'm planning to redo argument parsing for a few common tools using `llvm::Option` with TableGen generated options, I sent a short proposal on `llvm-dev` since Chandler suggested moving away from `llvm::cl` completely as far as actual LLVM tools go and leaving that interface for LLVM components since it serves more as a global registry for tweaking various aspects of LLVM with many passes registering options via that functionality and there are already discussions (on Phab) about problems with that approach even in that regard when multiple in-process instances of LLVM are desired.


Repository:
  rL LLVM

https://reviews.llvm.org/D53804