[PATCH] D53922: [clangd] fix non linux build

[Sam McCall via Phabricator via llvm-commits]

sammccall added a comment.

In https://reviews.llvm.org/D53922#1281902, @krytarowski wrote:

> In https://reviews.llvm.org/D53922#1281898, @sammccall wrote:
>
> > In https://reviews.llvm.org/D53922#1281882, @krytarowski wrote:
> >
> > > For NetBSD:
> > >
> > > - `ThreadPriority::Low` select either `SCHED_RR` or `SCHED_FIFO`, call sched_get_priority_min() and set pthread_setschedparam().
> >
> >
> > https://www.netbsd.org/docs/internals/en/chap-processes.htm indicates `SCHED_RR` and `SCHED_FIFO` are real-time priorities on NetBSD, as they are on linux.
> >  i.e. higher priority than normal threads, regardless of priority value.
>
>
> Priority level for SCHED_OTHER cannot be changed (it is dynamic), so the applied patch is fine.


Thanks. I was replying to your suggestion for NetBSD though - my reading of the docs says your "low" suggestion would end up being a very high priority.
Is this not the case? Can you suggest a better reference for how BSD scheduling works?


Repository:
  rL LLVM

https://reviews.llvm.org/D53922