[PATCH] D53804: [llvm-objdump] add support for '--reloc' as an alias of -r (PR39407)

[Kristina Brooks via Phabricator via llvm-commits]

kristina added a comment.

I think in this instance `-r` should not be hidden. And you'd need to override the default behavior by using `cl::NotHidden`. I spoke to Chandler and ideally we should start migrating common LLVM tools that substitute for binutils to a more user friendly `llvm::Option` based interface (kind of similar to what you mention regarding gnu-binutils) instead of the global `cl::` registry which is really intended for global LLVM options, but that can be done later as part of larger refactoring effort (which I'll need to bring up on `llvm-dev`). But ideally for now, while we're still using `cl::` I think it makes more sense if it's not hidden since it's a tool specific option.

I'll update the one I committed earlier for `-t` to not be hidden as well, but for now since this is still a diff, would you mind revising it?


https://reviews.llvm.org/D53804