[PATCH] D53804: [llvm-objdump] add support for '--reloc' as an alias of -r (PR39407)

Kristina Brooks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 31 00:31:17 PDT 2018


kristina added a comment.

In https://reviews.llvm.org/D53804#1281811, @Higuoxing wrote:

> Thank you everyone,
>
> In https://reviews.llvm.org/D53804#1281804, @kristina wrote:
>
> > Hm, maybe it would be a good idea to make the shorthand versions visible (since `cl::alias` implies `cl::Hidden` by default)? I feel like these aliases shouldn't be buried all the way in `--help-hidden` since they're pretty common.
>
>
> I agree with you. What if print help message like `gnu-objdump`?  I think we could make it more like `gnu-objdump`
>
> And here's another issue complain about `--help` option: https://bugs.llvm.org/show_bug.cgi?id=37895


That's a bit more complicated due to `llvm::cl` basically being the main hub for random parts of LLVM to register various hidden options for tinkering most of which you don't usually want to see. I think making it match GNU tools wouldn't serve much purpose but on the other hand I think that relevant shorthand flags shouldn't be hidden (where relevant to the tool in question either).

Would you mind revising this to make the alias non-hidden?


https://reviews.llvm.org/D53804





More information about the llvm-commits mailing list