[PATCH] D53675: [WebAssembly] Lower select for vectors

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:587
 
+multiclass SIMDSelectPat<ValueType vec_t, ValueType mask_t, ValueType lane_t,
+                         WebAssemblyRegClass reg_t> {
----------------
Why do we need this pattern? Can't we also expand `SELECT` as we did for `SELECT_CC` and `VSELECT`?


================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:601
+  // truncation produced by the legalizer when it converts i1s to
+  // i32s.
+  def : Pat<(vec_t (select
----------------
Nit: Wrap comments to 80 cols


Repository:
  rL LLVM

https://reviews.llvm.org/D53675