[PATCH] D50288: [ARM64] [Windows] Exception handling support in frame lowering

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 30 16:30:09 PDT 2018


rnk accepted this revision.
rnk added a comment.

Looks good, thanks!



================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:456
+  default:
+    assert(false && "No SEH Opcode for this instruction");
+  case AArch64::LDPDpost:
----------------
Please use llvm_unreachable instead of assert(false).


Repository:
  rL LLVM

https://reviews.llvm.org/D50288





More information about the llvm-commits mailing list