[PATCH] D52999: [FileCheck] Annotate input dump (1/7)

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 30 13:56:27 PDT 2018


jdenny updated this revision to Diff 171782.
jdenny retitled this revision from "[FileCheck] Annotate input dump" to "[FileCheck] Annotate input dump (1/7)".
jdenny edited the summary of this revision.
jdenny added a comment.

- Split up the patch.  This is now the first in the series.  Each patch has a description and example of the diagnostics for which it implements input annotations.
- Add the input file name and check file name to the annotations description to further address a reviewer concern.
- Don't use the word "key" to identify the annotations description because technically that's not what it is.


https://reviews.llvm.org/D52999

Files:
  llvm/docs/CommandGuide/FileCheck.rst
  llvm/include/llvm/Support/FileCheck.h
  llvm/lib/Support/FileCheck.cpp
  llvm/test/FileCheck/dump-input-annotations.txt
  llvm/test/FileCheck/dump-input-enable.txt
  llvm/test/FileCheck/match-full-lines.txt
  llvm/test/FileCheck/verbose_mode.txt
  llvm/utils/FileCheck/FileCheck.cpp
  llvm/utils/lit/lit/TestingConfig.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52999.171782.patch
Type: text/x-patch
Size: 40294 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181030/7e4d1746/attachment.bin>


More information about the llvm-commits mailing list