[PATCH] D53773: [ExecutionEngine] Track objects using an abstract ObjectKey in JITEventListeners.

[Andres Freund via Phabricator via llvm-commits]

anarazel requested changes to this revision.
anarazel added a comment.
This revision now requires changes to proceed.

This looks like a sensible improvement. There's probably not many implementors of the interface, so the renaming shouldn't cause much pain.

I noticed however that you didn't update ExecutionEngine/PerfJITEvents/PerfJITEventListener.cpp?



================
Comment at: lib/ExecutionEngine/MCJIT/MCJIT.cpp:653
+                               const RuntimeDyld::LoadedObjectInfo &L) {
+  uint64_t Key =
+      static_cast<uint64_t>(reinterpret_cast<uintptr_t>(Obj.getData().data()));
----------------
Perhaps this should rather live inside ObjectFile? No strong opinion, just pondering. Seems a bit prettier than having the ugly multiple cast in multiple places.


Repository:
  rL LLVM

https://reviews.llvm.org/D53773