[PATCH] D53880: [tblgen][PredicateExpander] Add the ability to describe more complex constraints on instruction operands.

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 30 12:45:46 PDT 2018


mattd accepted this revision.
mattd added a comment.
This revision is now accepted and ready to land.

LGTM!  Nice change!



================
Comment at: utils/TableGen/PredicateExpander.cpp:24
+                                              int ImmVal,
+                                              StringRef FunctionMapper) {
+  if (!FunctionMapper.empty())
----------------
Minor nit.  You name the formal parameter as 'FunctionMapper' but the function decl names the same parameter 'FunctionExpander'  Either name is fine (I prefer Expander).


https://reviews.llvm.org/D53880





More information about the llvm-commits mailing list