[PATCH] D53190: ARM: avoid infinite combining loop

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

> I thought the normal way to stop combining was to return the original node. Could you not manually replace N with Res and then return N?

You can sort of hide the new node from the worklist, but it's not usually a good idea: if the node gets back on the worklist some other way, you can end up with an infinite combining loop.  The goal should be a "stable" DAG, which DAGCombine won't modify further.


Repository:
  rL LLVM

https://reviews.llvm.org/D53190